On Tue, Nov 12, 2019 at 06:49:21AM -0700, Simon Glass wrote:
Hi Tom,
On Mon, 11 Nov 2019 at 07:18, Tom Rini trini@konsulko.com wrote:
On Fri, Nov 08, 2019 at 12:53:12PM -0700, Simon Glass wrote:
Create a new rand.h header file and move functions into it, to reduce the size of common.h
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2: None
include/common.h | 6 ------ include/net.h | 1 + include/rand.h | 40 ++++++++++++++++++++++++++++++++++++++++ lib/rand.c | 1 + net/link_local.c | 1 + 5 files changed, 43 insertions(+), 6 deletions(-) create mode 100644 include/rand.h
diff --git a/include/common.h b/include/common.h index 52bcc2e591..b09c7aeddd 100644 --- a/include/common.h +++ b/include/common.h @@ -325,12 +325,6 @@ char * strmhz(char *buf, unsigned long hz); /* lib/crc32.c */ #include <u-boot/crc.h>
-/* lib/rand.c */ -#define RAND_MAX -1U -void srand(unsigned int seed); -unsigned int rand(void); -unsigned int rand_r(unsigned int *seedp);
/*
- STDIO based functions (can always be used)
*/ diff --git a/include/net.h b/include/net.h index 75a16e4c8f..d8d187d8af 100644 --- a/include/net.h +++ b/include/net.h @@ -16,6 +16,7 @@ #include <asm/byteorder.h> /* for nton* / ntoh* stuff */ #include <env.h> #include <linux/if_ether.h> +#include <rand.h>
#define DEBUG_LL_STATE 0 /* Link local state machine changes */ #define DEBUG_DEV_PKT 0 /* Packets or info directed to the device */
OK, but common.h includes net.h, and I don't see this addressed further in the series. So this is a step in the right direction, but does it get messy to not include it?
Even after this series there are about another 40 functions to remove from common.h - once that is done I can look at dropping the includes.
I suspect it should be possible to remove net.h provided that it only includes network functions.
OK, so just laying ground work for future cleanups, I can accept that, thanks!
Reviewed-by: Tom Rini trini@konsulko.com