For environments stored on filesystems where you can't have a redundant configuration, rather than just over-writing the existing environment in fw_setenv, do the tradtional create temporary file, rename, sync, sync directory dance to achieve ACID semantics when writing through fw_setenv.
fw_env.c has had whitespace modified and HaveRedundEnv renamed in order to avoid triggering large numbers of checkpatch warnings because of the existing code style:
warning: space prohibited between function name and open parenthesis '(' check: Avoid CamelCase: <HaveRedundEnv>
Changes in v2: - Clean style violations in existing code - Acommodate white space changes from predecessor commit - Use mkstemp() to create temporary filename, not a fixed one
Alex Kiernan (4): tools: env: Pass through indent tools: env: Fix CamelCasing style violation tools: env: Refactor write path of flash_io() tools: env: Implement atomic replace for filesystem
tools/env/fw_env.c | 483 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 281 insertions(+), 202 deletions(-)