Re: [U-Boot] [PATCH] Add driver for the ST M41T94 SPI RTC

On Thu, Aug 13, 2009 at 01:05:37PM +0200, Stefan Roese wrote :

On Thursday 13 August 2009 12:14:30 Albin Tonnerre wrote:

...

This RTC is used in some Calao boards. The driver code is taken from the linux rtc-m41t94 driver

Signed-off-by: Albin Tonnerre albin.tonnerre@free-electrons.com

I guess the bin2bcd and bcd2bin functions belong somewhere in common/ rather than this particular driver ... Where should I put them ?

Currently we also have BIN2BCD/BCD2BIN macros in include/bcd.h. We should probably move to these lowercase inlined functions though. Perhaps you could create a patch to switch from BIN2BCD to bin2bcd in the RTC drivers and add those functions to bcd.h?

Heh, I see that nearly all the rtc drivers define those functions too ... Will submit a patch to clean that up

Regards,