Hi Masahiro,
On Mon, 11 May 2020 at 01:05, Masahiro Yamada masahiroy@kernel.org wrote:
On Mon, May 11, 2020 at 3:44 PM Masahiro Yamada masahiroy@kernel.org wrote:
Simon,
On Mon, May 11, 2020 at 7:58 AM Simon Glass sjg@chromium.org wrote:
Move this uncommon header out of the common header.
Signed-off-by: Simon Glass sjg@chromium.org
Why are you adding <init.h> to arch/arm/mach-uniphier/cpu-info.c, which does not include <common.h> in the first place?
This seems a wrong conversion.
For uniphier, NACK.
Hmm, are you fixing -Wmissing-prototypes, which is displayed with W=1 builds.
I wonder how bad it would be if we enabled that option?
If so, adding <init.h> to arch/arm/mach-uniphier/cpu-info.c makes sense although it is unclear from commit log.
But, I still do not understand why you are adding <init.h> to arch/arm/mach-uniphier/dram/umc-pxs2.c
It looks fine to me as-is.
Yes it is not needed - the dram_init() is throwing things off.
However given the scale of this series this seems like a small problem.
Regards, Simon