Re: [PATCH] apalis-imx8: Fix sc_misc_otp_fuse_read() error check

On Tue, Mar 12, 2024 at 9:59 PM Fabio Estevam festevam@gmail.com wrote:

Commit bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") made an incorrect logic change in the error code check of sc_misc_otp_fuse_read():

•   if (scierr == SC_ERR_NONE) {
  

•   if (scierr) {
            /* QP has one A72 core disabled */
            is_quadplus = ((val >> 4) & 0x3) != 0x0;
    }
  
  

The other changes in this commit are correct.

sc_misc_otp_fuse_read() returns 0 on a successful fuse read.

This inversion causes board_mem_get_layout() to report incorrect RAM size.

Go back the original error check logic to fix the problem.

Fixes: bfb3409d676f ("imx: toradex/apalis-imx8: correct SCU API usage") Signed-off-by: Fabio Estevam festevam@gmail.com

Applied for u-boot-imx/master, thanks.