14 Dec
2022
14 Dec
'22
5:39 a.m.
On Fri, 9 Dec 2022 at 08:15, Sergei Antonov saproj@gmail.com wrote:
Support Holtek HT1380/HT1381 Serial Timekeeper Chip. It provides seconds , minutes, hours, day of the week, date, month and year information.
Datasheet: https://www.holtek.com.tw/documents/10179/11842/ht1380_1v130.pdf
Signed-off-by: Sergei Antonov saproj@gmail.com
v3: Suggested by Simon Glass:
- remove extra brackets
- pass GPIOD_IS_OUT to gpio_request_by_name() and drop the extra code below
- add text to Kconfig: how it is connected, i.e. three GPIOs
- rename dts names to plural: rst/clk/dat-gpios
Suggested by Tom Rini:
- enable on sandbox so that it gets build tested
v2:
- The RESET pin is now to be described as ACTIVE_LOW in dts.
Changes suggested by Simon Glass:
- a more detailed driver description in Kconfig
- multi-line comments' style
- enum for 0x80 and the 0x20 at top of file
- lower-case hex constants
- function comments for ht1380_reset_on/off
- blank line before returns
configs/sandbox_defconfig | 1 + drivers/rtc/Kconfig | 9 ++ drivers/rtc/Makefile | 1 + drivers/rtc/ht1380.c | 329 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 340 insertions(+) create mode 100644 drivers/rtc/ht1380.c
Reviewed-by: Simon Glass sjg@chromium.org