Hi Guillaume,
Thank you for the patch.
On jeu., oct. 17, 2024 at 18:10, Guillaume La Roque glaroque@baylibre.com wrote:
Rename actual android bootmethod test to specify it's for boot image version 4. Add a unit test for testing the Android bootmethod with boot image version 2.
This requires another mmc image (mmc8) to contain the following partitions:
- misc: contains the Bootloader Control Block (BCB)
- boot_a: contains a fake generic kernel image
we can test this with:
$ ./test/py/test.py --bd sandbox --build -k test_ut # build the mmc8.img $ ./test/py/test.py --bd sandbox --build -k bootflow_android
Signed-off-by: Guillaume La Roque glaroque@baylibre.com
arch/sandbox/dts/test.dts | 10 +++++++++- test/boot/bootflow.c | 29 +++++++++++++++++++++++++--- test/py/tests/test_ut.py | 49 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 84 insertions(+), 4 deletions(-)
diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts index 9bf44ae3b0bc..108633a727f9 100644 --- a/arch/sandbox/dts/test.dts +++ b/arch/sandbox/dts/test.dts @@ -44,6 +44,7 @@ mmc5 = "/mmc5"; mmc6 = "/mmc6"; mmc7 = "/mmc7";
mmc8 = "/mmc8";@@ -1135,13 +1136,20 @@ filename = "mmc6.img"; };
- /* This is used for Android tests */
- /* This is used for Android tests image v4 tests */
Nit: we are repeating "tests" twice here. Maybe rephrase to "This is used for Android boot image v4 tests" ?
With the nit addressed:
Reviewed-by: Mattijs Korpershoek mkorpershoek@baylibre.com
[...]
mmc7 {
-- 2.34.1