Tom wrote:
Dirk Behme wrote:
Tom Rix wrote:
From: Syed Mohammed Khasim khasim@ti.com
This was cherry-picked from
repo: http://www.beagleboard.org/u-boot-arm.git commit: 52eddcd07c2e7ad61d15bab2cf2d0d21466eaca2
In addition to adding multibus support, this patch also cleans up the register access. The register access has been changed from #defines to a structure.
Have you looked at my proposal I sent some hours before your patch?
Sorry. I did not. Not surprisingly it looks similar.
The formatting changes you mentioned were part of the original cherry-picked commit. I tried to leave as much of the original commit intact as possible. I ran but ignored the output of checkpatch.. The biggest complaint it has is with 80 char lines.
I looked over your patch. It looks like an improvement to mine.
I'm all for dropping mine and using yours. I will run test yours.
Do you have a zippy board that you can use to test the 2nd bus ?
Dirk,
Some feedback.
No regressions on MAKEALL arm
I ran tested your patch Zoom1 and Beagle. Default i2c looks good. I did not test the multibus support.
Looks good, please officially submit your patch.
Tom
Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot