-----Original Message----- From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj@jcrosoft.com] Sent: Friday, April 17, 2009 1:06 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de; Ashish Karkare; Ronen Shitrit; Ben Warren Subject: Re: [U-Boot] [PATCH v4] Marvell MV88E61XX Switch Driver support
On 18:54 Wed 15 Apr , Prafulla Wadaskar wrote:
Chips supported:-
- 88E6161 6 port gbe swtich with 5 integrated PHYs 2.
88E6165 6 port
gbe swtich with 5 integrated PHYs 2. 88E6132 3 port gbe
swtich with 2
integrated PHYs Platform specific configuration supported
Note: This driver is supported and tested against kirkwood egiga interface
Contributors: Yotam Admon yotam@marvell.com Michael Blostein <michaelbl@marvell.com
Reviewed by: Ronen Shitrit rshitrit@marvell.com Signed-off-by: Prafulla Wadaskar prafulla@marvell.com
Changelog:- v2: updated as per review comments for v1 removed other two drivers form earlier patch debug_prints removed driver moved to drivers/net/
v3: updated as per review comments for v2 miiphy interface used, platform specific dependency resolved Chip id detection and
printing
added common code forked out some cosmetic and magic number fixes
v4: updated as per review comments for v3 mv88e61xx.h added
platform
specific configuration support added some more documentation references provided cleaned rgmii delay enable related code
this version looks better
I've just 2 comments on it
Thanks jean.... :-)
- drivers/net/phy/ is for phylib and drivers as a switch can
be consider as a multiple phy port please move it there
Okay... I will move this driver to suggested location.
- the Vlan init is not so clear for people who need to
maintain or update the code as the Marvell's switch datasheets are all under NDA
The name vlan init may be confusing. I can easily put this in platform specific code, but this is very common combination used most of the boards. So there will be unnecessary code duplication. I will restructure and rename it to the proper switch use case so that it will be clear to most of the users.
Regards.. Prafulla . .
Best Regards, J.