On Sat, Feb 10, 2018 at 10:01 AM, Lukasz Majewski lukma@denx.de wrote:
Hi Alex,
On Fri, Feb 9, 2018 at 10:50 PM, Lukasz Majewski lukma@denx.de wrote:
diff --git a/configs/mx53ppd_defconfig b/configs/mx53ppd_defconfig index 3fbca2a08c..b83cf72022 100644 --- a/configs/mx53ppd_defconfig +++ b/configs/mx53ppd_defconfig @@ -21,6 +21,7 @@ CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y CONFIG_CMD_FS_GENERIC=y CONFIG_BOOTCOUNT=y +CONFIG_BOOTCOUNT_LIMIT=y CONFIG_BOOTCOUNT_EXT=y CONFIG_SYS_BOOTCOUNT_EXT_DEVPART="0:5" CONFIG_NETDEVICES=y
...
diff --git a/drivers/bootcount/Kconfig b/drivers/bootcount/Kconfig index c9d627cce2..cb6be73d52 100644 --- a/drivers/bootcount/Kconfig +++ b/drivers/bootcount/Kconfig @@ -11,6 +11,12 @@ config BOOTCOUNT number of times the board has booted on a number of different persistent storage mediums.
+config BOOTCOUNT_LIMIT
bool "Enable support for checking boot count limit"helpEnable checking for exceeding the boot count limit.More information:http://www.denx.de/wiki/DULG/UBootBootCountLimit + if BOOTCOUNT
config BOOTCOUNT_EXT
Can't CONFIG_BOOTCOUNT and CONFIG_BOOTCOUNT_LIMIT be merged?
This patch was mostly generated by moveconfig utility.
Yeah, I've a similar patch series where I'd done the same thing.
config BOOTCOUNT bool "Enable Boot count support" help Enable boot count support, which provides the ability to store the number of times the board has booted on a number of different persistent storage mediums.
AFAICT mx53ppd is the only board which has CONFIG_BOOTCOUNT set,
I would use pragmatic approach here - leave this patch as is, and prepare next one on top of it to replace CONFIG_BOOTCOUNT with CONFIG_BOOTCOUNT_LIMIT (as the last one is used in many places).
BOOTCOUNT is just used within Kconfig, not actually consumed either by a Makefile or any piece of code and should probably go?
Yes. It could be replaced with CONFIG_BOOTCOUNT_LIMIT.
Broadly what I had, only I'd reused the description from CONFIG_BOOTCOUNT. I also worked through all the drivers, and made bootlimit configurable from Kconfig. But I see you're doing way more work around BOOTCOUNT, so I'll hold off on them.