On Fri, Sep 28, 2012 at 11:18:04AM +0200, Pavel Herrmann wrote:
Move all extern declarations of sata_dev_desc[] into <sata.h> to make checkpatch happy, inslude <sata.h> in every sata driver, and remove now duplicit declarations of sata API functions.
Signed-off-by: Pavel Herrmann morpheus.ibis@gmail.com
Not a problem in your patch, but a problem exposed by your patch is that the prototypes in <ide.h> for ide_{read,write} and in <sata.h> for sata_{read,write} do not match what <part.h> says block_dev_desc_t says block_{read,write} should have. I'm correcting these, and then the driver fall-out. I also see that DM corrects this problem as well as the logical problem we have today (block_{read,write} uses different types for starting point and number to read). However, I don't feel it's good to take these changes in for v2012.10 so it'll be put into -next. Thanks for your patience and re-working of things.