Re: [U-Boot] [PATCH 2/2] armv8/ls1046a: RGMII PHY requires internal delay on Tx

On 04/04/2017 04:44 AM, Madalin Bucur wrote:

Signed-off-by: Madalin Bucur madalin.bucur@nxp.com

drivers/net/fm/ls1046.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/fm/ls1046.c b/drivers/net/fm/ls1046.c index bf55554..6c91fb9 100644 --- a/drivers/net/fm/ls1046.c +++ b/drivers/net/fm/ls1046.c @@ -72,12 +72,12 @@ phy_interface_t fman_port_enet_if(enum fm_port port) if (port == FM1_DTSEC3) if ((rcwsr13 & FSL_CHASSIS2_RCWSR13_EC1) == FSL_CHASSIS2_RCWSR13_EC1_DTSEC3_RGMII)

• 	return PHY_INTERFACE_MODE_RGMII;
  

• 	return PHY_INTERFACE_MODE_RGMII_TXID;
  
  

  if (port == FM1_DTSEC4) if ((rcwsr13 & FSL_CHASSIS2_RCWSR13_EC2) == FSL_CHASSIS2_RCWSR13_EC2_DTSEC4_RGMII)

• 	return PHY_INTERFACE_MODE_RGMII;
  

• 	return PHY_INTERFACE_MODE_RGMII_TXID;
  
  

  /* handle SGMII, only MAC 2/5/6/9/10 available */ switch (port) {

I don't know what test you have run. This change breaks network on LS1043ARDB FM1@DTSEC3.

York