-----Original Message----- From: wd@denx.de [mailto:wd@denx.de] Sent: Friday, July 06, 2007 2:56 AM To: Jin Zhengxiong-R64188 Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [PATCH 0/3]Patchset for Ati bios emulator and Ati frambuffer driver
Hello,
in message <CC27DED0F8F39E48A7E75FD768688B7A3E97A2@zch01exm27.fsl.freesca le.net> you wrote:
Please restrict your line length to < 80 characters or so when posting, and make sure to read the patch submission rules - see http://www.denx.de/wiki/UBoot/Patches
Each of the two patch is a logical part and I think they
should not be
split into separate part, I'll try to provide a URL for the
two patches.
Well, ok, but actually this has nothing to do with the line length of your postings on this mailing list, right?
Ok, I'll try to fix this next time. And I'm trying to find a place to put the patch.
Ati bios emulator - Why do we need another emulator? Is
the one we
have in board/MAI/bios_emulator/ not sufficient for your purposes?
Yes, I found there's a bios_emulator in
board/MAI/bios_emulator, but
it's board specific and I can not use it directly, actually both of the emulator come from Scitech, I tried to make it clean and clear during my porting. On the other side, I tried to compile it for the MAI board but compile failed. If other board want to use the bios emulator, I suggest
moving it out
from the board and make it clean.
Can you please do that, then? It's the logic consequence. I do not want to add another 800 kB of code for a feature that is already present. If cleanup and.or generalization is needed, then this is what has to be done. If you find that your solution is better than the existing one, you have to prove that and replace the old one.
Actually, The BIOS emulator I posted and the BIOS emulator in board/MAI are both come from SciTech. But as it's under the MAI board, my understand is if I want to use it for different platforms, I need to move it out and try to cleanup it and make it pass compile and make it work (The BIOS emulator under MAI board is about 6M and I don't know if some files such as the bat files and win32 directory is useful for u-boot).
So I think it can be interpretated as I've moved out and cleanup the BIOS emulator from MAI board. But I haven't MAI board in hand and can not test if the board can work normally after remove the bios_emulator. So I did not send a patch to remove the code in the board/MAI. I can only test this 'moved out' BIOS emulator on the board in hand such as 85xx,86xx and 7448 board. If I can contact with the maintainer of the MAI board. Maybe she or he can help to test this.
Thanks Jason