Re: [U-Boot] [PATCH 22/27] pcs440ep: get mac address from environment and move load_sernum_ethaddr() to board init

Dear Mike,

In message 200902161905.12952.vapier@gentoo.org you wrote:

...

...

+void load_sernum_ethaddr (void) +{ +}

See previous comments - please do not add dead code just to remove it later.

your previous comment doesnt apply to these later ones. the first change is for arm-only. the later changes are for ppc. it isnt dead code because the function is still called by common ppc code. just like i outlined in the summary for this patchset.

Well, there is a very small number of boards. Why cannot we have this change in one step, in one commit? Adding empty functions just to remove them later seems sub-optimal to me.

Best regards,

Wolfgang Denk