Re: [U-Boot] [PATCH v2] [x86] Add a basic implementation for a coreboot board

i'm not terribly familiar with what it takes to make an x86 board, but i don't see anything jumping out of this patch.

i would note however that you should merge the boards.cfg update into this patch. merging one or the other doesn't make much sense, and there's no reason to keep them split.

+void setup_pcat_compatibility()

should be "(void)" -mike