Re: [U-Boot] [PATCH v4] video: atmel: implement lcd_setcolreg funtion

Hi Marek Vasut,

On 11/8/2012 21:08, Marek Vasut wrote:

Dear Bo Shen,

[...]

...

+/*

• • the CLUT register map as following
• • RCLUT(24 ~ 16), GCLUT(15 ~ 8), BCLUT(7 ~ 0)
• */

+void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue) +{

• lcdc_writel((red << 16) & 0xff0000 | (green << 8) & 0xff00 |

• blue & 0xff, panel_info.mmio + ATMEL_LCDC_LUT(regno));
  

+}

Why don't you #define these values instead?

Ok, I will change to use #define.

Thanks,

Best Regards, Bo Shen