9 Sep
2010
9 Sep
'10
6:43 p.m.
include/apm821xx.h | 493
+++++++++++++++++++++++++++++++
I know that Wolfgang specifically asked you to add this file for this "new" SoC. But I'm not so sure if this is the right way. Most of the defines in this new file are a plain copy from include/ppc440.h.
Wolfgang, do you really think this is better than adding support for this SoC into ppc440.h? After all, the CPU core of this SoC is still a PPC4xx PowerPC.
It makes no sense to duplicate common parts. Only different code should be moved to separate files.
[Marri] It is only few lines of code is different. Any way I will make a change and Send it. Regards, Marri