On Fri, Mar 8, 2024 at 1:24 PM McAllister, Colin Colin.McAllister@garmin.com wrote:
Ah, ok, I see you replied to my comment here.
Yes, sorry. Outlook is terrible to send inline responses too. I figured just adding responses in the patch contents would be better. Next time I'll submit my patch with a different email :)
So when that config option is not defined at all, the build still works, right?
Yes, the default value for CONFIG_ANDROID_AB_BACKUP_OFFSET is 0x0, which would evaluate to a false bool value in the if conditions. I did do some testing with the config value not defined for my board and confirmed back-up data is not used.
Looks good to me, thanks.
In your other emails you include your reviewed-by tag. For clarity, Am I supposed to append my patches and upload a new version? This is my first time contributing to u-boot, so I'm still learning the workflow. I didn't see anything glancing through the "Sending patches" page in the U-Boot documentation.
Welcome to the community! And thanks for your patches :) U-Boot workflow is quite similar to Linux kernel one. It's useful to collect all tags when sending out your next version. When the maintainer takes your patch, they usually also apply all R-b tags for the final patch version, so you only have to worry about that when sending out a new version. I know that U-Boot contributors are often using `patman' tool [1] for submitting patches (and corresponding updated versions), and I'm pretty sure it collects all pending tags automatically for you. FWIW, I'm not experienced with `patman', as I'm trying to use somehow unified submitting process for both U-Boot and Linux kernel, and I know that using `patman' is sometimes discouraged in Linux kernel community.
[1] https://docs.u-boot.org/en/latest/develop/patman.html
[snip]