
On Monday 10 March 2008, Alex Raimondi wrote:
This patch adds support for our new AVR32 based board.
Your patch is line wrapped. Please fix this and resubmit. One quick comment without looking too deep into your patch:
You are introducing a board specific flash driver. This should not be necessary anymore, since the common CFI driver now also has an interface to support non CFI compatible flash chips. What flash chips are you using? Please see actux4 for example (CFG_FLASH_LEGACY_256Kx8).
I will check your point with the flash driver...
Hope this time the patch is not line wrapped.
It is again. I suggest that you first send this message to yourself, until you figured out how to do it correctly. And if you are working with git, I strongly encourage you to use git-send-email to send patches.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================