On Tue, May 21, 2013 at 02:42:02PM -0500, Scott Wood wrote:
Please change the title and the rest of the changelog to describe what functionality you're adding and why.
On 05/20/2013 01:07:27 AM, ying.zhang@freescale.com wrote:
diff --git a/common/env_common.c b/common/env_common.c index 906b41f..8cb81e9 100644 --- a/common/env_common.c +++ b/common/env_common.c @@ -156,7 +156,6 @@ int set_default_vars(int nvars, char * const vars[]) H_NOCLEAR | H_INTERACTIVE, nvars, vars); }
-#ifndef CONFIG_SPL_BUILD /*
- Check if CRC is valid and (if yes) import the environment.
- Note that "buf" may or may not be aligned.
@@ -188,7 +187,6 @@ int env_import(const char *buf, int check)
return 0; } -#endif
This ifndef was introduced by Ilya Yanok in commit 7ac2fe2da21d292aeaf3af74e5c80de9ce9dab56.
Ilya, what are the consequences of removing this? Is there some other symbol we can use here?
This was likely done so that we could fit the combination of USB RNDIS networking in SPL into the size constraint we have and the need for more than just unused section discarding to get rid of codepaths we know won't be taken (but couldn't compile-time determine).