On Monday 06 July 2009 10:47:41 Stefan Roese wrote:
i guess each flash type would parse the additional commands however it liked and so the mtd command would just act as a multiplexer at this point. the current spi flash "sf" command is pretty flexible -- you specify the spi chip select to select the device and you can specify other parameters dynamically (like frequency). so when folding it in, we'd have: => mtd device sf <cs> [speed] [mode]
common/cmd_mtd.c common/cmd_mtd_sf.c common/cmd_mtd_nor.c
I was more thinking about adding the MTD layer to all FLASH types supported by this new commandset. Then accessing the device is done via the MTD functions pointers (mtd->erase, mtd->read, etc). Special FLASH type specific stuff still needs to be handled in some additional drivers (like OOB handling for NAND/OneNAND, or SF specific stuff) though.
ok, this seems like it should be doable in a gradual progression. i.e. today i am only concerned with nor flash, so getting a base framework with that as the only supported flash should be fine. once we know it can replace the existing cmd_flash.c functions, we can look at folding in other flash types. -mike
I think this is a doable approach. But we first need a general consent on this. Other opinions on this are welcome...
No further responses on this. So it seems nobody objects this approach to move to a common command interface for all flash types.
Mike, what are your plans here? Will you work in this "mtd" commands interface at some time?
Thanks.
Best regards, Stefan
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de =====================================================================