Re: [U-Boot] [PATCH 1/3] Update Makefile for new dirs to be included in tag list

On Wednesday 09 December 2009 01:26:06 Li Yang wrote:

diff --git a/Makefile b/Makefile index bcb3fe9..4d71366 100644 --- a/Makefile +++ b/Makefile +TAG_SUBDIRS += $(shell if [ -d board/$(VENDOR)/common ]; then echo \

• "board/$(VENDOR)/common"; fi)

ugh, dont do that. using $(shell) is awful. if you need to do things based on a dynamic path, use: ifneq ($(wildcard some/path),) ... endif

perhaps even better would be to let each dir define a tags.in or something and have the toplevel Makefile source that -mike