
Hi Daniel,
On 01/08/19 9:51 PM, Daniel Schwierzeck wrote:
diff --git a/drivers/core/read.c b/drivers/core/read.c index 1a044b05e884..8b5502de1159 100644 --- a/drivers/core/read.c +++ b/drivers/core/read.c @@ -82,6 +82,15 @@ fdt_addr_t dev_read_addr_index(struct udevice *dev, int index) return devfdt_get_addr_index(dev, index); }
+fdt_addr_t dev_read_addr_size_index(struct udevice *dev, int index,
fdt_size_t *size)
+{
if (ofnode_is_np(dev_ofnode(dev)))
return ofnode_get_addr_size_index(dev_ofnode(dev), index, size);
else
return devfdt_get_addr_size_index(dev, index, size);
+}
void *dev_remap_addr_index(struct udevice *dev, int index) { fdt_addr_t addr = dev_read_addr_index(dev, index); @@ -102,6 +111,17 @@ fdt_addr_t dev_read_addr_name(struct udevice *dev, const char *name) return dev_read_addr_index(dev, index); }
maybe it makes sense to update the dev_remap_* variants to utilise the new dev_read_addr_* to be able to pass a valid size to map_physmem()? Currently a size of 0 is passed due to the lack of function which you are adding now.
Thanks for pointing that out. I think this is something that can come as a follow-on series. This series itself was supposed to go into 2019.10, but held up due to a stupid bug I introduced.
I will send a v4 today with a commit message change that was asked with the hope that it can get into 2019.10 still.
Thanks, Sekhar