On Fri, May 11, 2012 at 03:09:25PM +0100, Jamie Lentin wrote:
Are you sure you need this CONFIG_RESET_PHY_R at all? I mean I have the same SoC and I do not need this at all. I think this part is left over from other boards that we do not need anymore. It makes sense to remove this if you do not need it on your board.
Take a look here:
http://git.denx.de/?p=u-boot/u-boot-arm.git;a=blob;f=board/raidsonic/ib62x0/...
I've fiddled for a while and cannot get a working Ethernet connection without this code to enable RGMII delay. Tried cloning configs/ib62x0.h, but no luck. Presumably you have the same PHY chip (88E1116R-NNC1) too?
I'm not sure... But if you really need this info I will disassemble the box and take a look.
Anyway I'm glad you have double checked this.
Agree that it's a copy and pasted chunk of code that shouldn't be there though and at least should find a common home somewhere.
Probably, but this is unrelated to this patch.
I have no more questions regarding this patch...
Regards, Luka