On Tuesday 24 July 2018 02:14 PM, Peng Fan wrote:
Hi Faiz,
It's 2 months since this patchset out (:
Has it already been accepted?
No. I did not receive response from Jaehoon.
drivers/mmc/Kconfig
On Saturday 19 May 2018 06:24 PM, Peng Fan wrote:
Add HS400 support. Selecting HS400 needs first select HS199 according to spec, so use a dedicated function for HS400. Add HS400 related macros. Remove the restriction of only using the low 6 bits of EXT_CSD_CARD_TYPE, using all the 8 bits.
Signed-off-by: Peng Fan peng.fan@nxp.com Cc: Jaehoon Chung jh80.chung@samsung.com Cc: Jean-Jacques Hiblot jjhiblot@ti.com Cc: Stefano Babic sbabic@denx.de Cc: Simon Glass sjg@chromium.org Cc: Kishon Vijay Abraham I kishon@ti.com Cc: Bin Meng bmeng.cn@gmail.com
V3: Simplify code add error msg
V2: remove 4bits support from HS400, as HS400 does not support 4bits per
spec.
drivers/mmc/Kconfig | 7 +++ drivers/mmc/mmc.c | 137
+++++++++++++++++++++++++++++++++++++++++-----------
include/mmc.h | 11 +++++ 3 files changed, 128 insertions(+), 27 deletions(-)
diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 3f15f85efd..a535a87a8e 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -104,6 +104,13 @@ config SPL_MMC_UHS_SUPPORT cards. The IO voltage must be switchable from 3.3v to 1.8v. The bus frequency can go up to 208MHz (SDR104)
+config MMC_HS400_SUPPORT
- bool "enable HS400 support"
- select MMC_HS200_SUPPORT
- help
The HS400 mode is support by some eMMC. The bus frequency is upto
200MHz. This mode requires tuning the IO.Please add SPL_MMC_HS400_SUPPORT also.
What issue do you see? I did not test SPL MMC with HS400 support. You mean only add a Kconfig entry SPL_MMC_HS400_SUPPORT?
Yes only a Kconfig. It helps people who want to include/exclude it from SPL. You are implicitly checking for the config in CONFIG_IS_ENABLED(MMC_HS400_SUPPORT) below.
I was just using your patch for some out of tree development and figured it would be useful to have the CONFIG.
Ok. I'll add it and post out V4 patchset.
Thanks, Peng
Thanks, Faiz