Hi Florian,
On Thu, 2020-02-20 at 11:05 -0800, Florian Fainelli wrote:
On 2/20/20 8:36 AM, Nicolas Saenz Julienne wrote:
As per Linux's driver, ID_MODE_DIS is only set when the PHY interface is RGMII. Don't enable it for the rest of setups.
This has been seen to misconfigure RPi4's PHY when booting Linux.
Signed-off-by: Nicolas Saenz Julienne nsaenzjulienne@suse.de
Does the failure look like the following: you have a driver for the Broadcom PHY used on the Pi4 in u-boot, and the phy_dev->interface value is being used to configure the Ethernet PHY chip in a certain way.
Later when you boot Linux, you do not have CONFIG_BROADCOM_PHY enabled so the Generic PHY driver gets used instead, and there is a disagreement between the AMAC and PHY as to whom should be adding the delays?
I added an explanation to Matthias' response. I think it fits yours, modulo my limited knowledge in the area :)
At any rate:
Reviewed-by: Florian Fainelli f.fainelli@gmail.com
Thanks!
Regards, Nicolas