Hi Rai,
On Mon, 24 Jun 2013 09:28:26 +0000, Rai Harninder-B01044 B01044@freescale.com wrote:
Hello Albert,
Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok?
(weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?)
As for the commit summary, it is fine by me.
Also, when touching on a board's code, you should Cc: the board's maintainer(s). Please do so for V2 of your patch -- and if you get a non-delivery status (e.g. a maintainer's mail address does not exist any more), please follow up on your patch submission to let us know. [Rai Harninder-B01044] The board's maintainer is Andy Fleming who is already included in cc
Are you not mixing up BSC9131RDB and BSC9132QDS maintainership with MPC85xx tree custodianship?
Andy is the MPC85xx custodian, but has no entry in the MAINTAINERS file, which OTOH lists Poonam Aggrwal poonam.aggrwal@freescale.com as the BSC9131RDB maintainer, and Naveen Burmi NaveenBurmi@freescale.com as the BSC9132QDS one.
Harry++
Amicalement,