Re: [PATCH 1/2] net: tsec: only call tsec_get_interface as fallback to DT-specified PHY mode

On Sun, Sep 19, 2021 at 10:32 AM Bin Meng bmeng.cn@gmail.com wrote:

On Sat, Sep 18, 2021 at 8:47 PM Vladimir Oltean vladimir.oltean@nxp.com wrote:

...

Currently the init_phy function may overwrite the priv->interface property, since it calls tsec_get_interface which tries to determine it dynamically based on default register values in ECNTRL.

Let's do that only if phy-connection-type happens to not be defined in the device tree.

Signed-off-by: Vladimir Oltean vladimir.oltean@nxp.com

drivers/net/tsec.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)

Reviewed-by: Bin Meng bmeng.cn@gmail.com Tested-by: Bin Meng bmeng.cn@gmail.com

Reviewed-by: Ramon Fried rfried.dev@gmail.com