
14 Oct
2008
14 Oct
'08
10:52 p.m.
Dear Timur,
In message 1222959963-5697-1-git-send-email-timur@freescale.com you wrote:
All implementations of the functions i2c_reg_read() and i2c_reg_write() are identical. We can save space and simplify the code by converting these functions into inlines and putting them in i2c.h.
Signed-off-by: Timur Tabi timur@freescale.com
I'm posting this patch because I'm enhancing the I2C routines to support multiple I2C busses more easily, but I need to clean up the existing code first.
What about resubmitting this patch, with adding a debug() to the new, common i2c_reg_read() and i2c_reg_write() funtions?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
"If people are good only because they fear punishment, and hope for
reward, then we are a sorry lot indeed." - Albert Einstein