Re: [U-Boot-Users] [PATCH 2/2] Remove the obsolete terse version of do_mii()

gvb.uboot wrote:

Thanks for the patch to clean this up. While I agree with the patch, I would appreciate respinning it:

• I should be an "Acked by" rather than a signed off by since I didn't

do anything to generate the patch itself.

As you are the original writer, IMHO you could/should signed-off-by :-) But it was my bad to add your sign without asking you. I'll resubmit the patch later with your acked-by.

• I would also offer the following summary rather than quoting my

original email (including the 6(!) year reference, which will look kinda funny in 2012 ;-):

Remove the "terse" version of the mii command, eliminating an #ifdef and apparently unused code. The space savings of the "terse" version is not significant and it isn't worth the extra maintenance effort to keep it.

Thanks for your kind summary.

Shinya