Re: [U-Boot] [PATCH 2/2] x86: qemu: qfw: Implement acpi_get_rsdp_addr()

On Tue, Jan 30, 2018 at 9:01 PM, Bin Meng bmeng.cn@gmail.com wrote:

U-Boot on QEMU does not build ACPI table by ourself, instead it uses the prebuilt ACPI table via the qfw interface. This implements the qfw version of acpi_get_rsdp_addr() for setup_zimage().

Signed-off-by: Bin Meng bmeng.cn@gmail.com

drivers/misc/qfw.c | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/drivers/misc/qfw.c b/drivers/misc/qfw.c index a8af9e0..9a54803 100644 --- a/drivers/misc/qfw.c +++ b/drivers/misc/qfw.c @@ -222,6 +222,14 @@ out: free(table_loader); return addr; }

+ulong acpi_get_rsdp_addr(void) +{

•   struct fw_file *file;
  

•   file = qemu_fwcfg_find_file("etc/acpi/rsdp");
  

•   return file->addr;
  

qemu_fwcfg_find_file() can return NULL. Don't we need to check that ? Or can we assume etc/acpi/rsdp is always present ?

Sorry for the late response.

Miao

+} #endif

/* Read configuration item using fw_cfg PIO interface */

2.7.4