Hi,
On 08/05/2014 09:02 AM, Ian Campbell wrote:
On Sun, 2014-08-03 at 05:32 +0300, Siarhei Siamashka wrote:
This is version 2 of http://lists.denx.de/pipermail/u-boot/2014-July/183981.html
Rebased on git://git.denx.de/u-boot-sunxi.git master branch (commit 3340eab26d89176dd0bf543e6d2590665c577423 "sun7i: Add bananapi board")
This all looks great, thanks!
Indeed, many thanks for working on this and for the rebase.
I think this should be the primary subject of the next sunxi PR. A change of this magnitude really ought to be in an rc1 so hopefully there won't be any significant changes required (it doesn't look like there should be to me).
I'm AFK from tomorrow until after when I expect rc1 to be so I'm not around to prepare a PR -- Hans can you take care of it (if you agree with my assessment of the patches, of course)? I've delegated them to you in pw in anticipation.
Ok, I've also reviewed this, and ran some tests, and this looks good, I agree with trying to get this into RC-1.
But currently we already have a pull-req pending for Albert. So for now I've pushed this to u-boot-sunxi/next, with u-boot-sunxi/master still reflecting the pull-req send to Albert.
I guess it is probably best to send a new pull-req to Albert superseding the old one. Albert how would you prefer to handle this ?
Regards,
Hans
p.s.
Siarhei Siamashka, I've seen your "Single u-boot binary" patches, and I'll try to review them during the coming days.