Re: [U-Boot] [PATCH] phy: ti: Init node before reading

Hi,

On 18. 03. 19 9:38, Lukasz Majewski wrote:

Hi Michal,

...

There is a need to fill node before clk_output_sel is setup.

Could you be more specific about this issue ?

I assume that the issue is on a system where Xilinx is used. I did my work/testing on a system where TI's SoC was used instead, so I'm curious what are the problems on Xilinx.

I didn't run this on any board - it is just fixing logic there.

Just look at the code that this. ofnode_read_u32_default(node, "ti,clk-output-sel",

is using node. But node variable is not initialized at that time. It initialized below this. It means I expect that this read will always setup default value no matter what you have in ti,clk-output-sel property.

Thanks, Michal