On 22/10/2018 10:48, Lars Povlsen wrote:
When changing some MIPS configs from CONFIG_OF_EMBED to CONFIG_OF_SEPARATE, I ran into this compile issue since SPL is not enabled. The fix is to guard the <spl.h> header with the CONFIG_SPL_LIBCOMMON_SUPPORT preprocessor symbol.
It seems that the <spl.h> is not needed even when SPL is enabled, but I'm not 100% sure on that. The code at lines 55..57 guarded by CONFIG_SPL_LIBCOMMON_SUPPORT does not require the <spl.h> header file.
Signed-off-by: Lars Povlsen lars.povlsen@microsemi.com
common/common_fit.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/common/common_fit.c b/common/common_fit.c index 577b352..33e26cc 100644 --- a/common/common_fit.c +++ b/common/common_fit.c @@ -8,7 +8,9 @@ #include <errno.h> #include <image.h> #include <linux/libfdt.h> +#ifdef CONFIG_SPL_LIBCOMMON_SUPPORT #include <spl.h>
I believe that spl.h is not needed at all here. It should be removed JJ
+#endif
ulong fdt_getprop_u32(const void *fdt, int node, const char *prop) {