Re: [PATCH] colibri-imx8x: Fix sc_misc_otp_fuse_read() error check

On Tue, Mar 12, 2024 at 9:36 PM Fabio Estevam festevam@gmail.com wrote:

Commit aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") made an incorrect logic change in the error code check of sc_misc_otp_fuse_read():

•   if (sc_err == SC_ERR_NONE) {
  

•   if (sc_err) {
            /* DX has two A35 cores disabled */
            return (val & 0xf) != 0x0;
    }
  
  

The other changes in this commit are correct.

sc_misc_otp_fuse_read() returns 0 on a successful fuse read.

This inversion causes board_mem_get_layout() to report incorrect RAM size.

Go back the original error check logic to fix the problem.

Fixes: aa6e698a7acd ("imx: toradex/colibri-imx8x: correct SCU API usage") Reported-by: Hiago De Franco hiago.franco@toradex.com Signed-off-by: Fabio Estevam festevam@gmail.com

Applied for u-boot-imx/master, thanks.