Re: [U-Boot] [PATCH v7 4/7] mips: ath79: add serial driver for ar933x SOC

On 16 January 2016 at 11:13, Wills Wang wills.wang@live.com wrote:

Reviewed-by: Thomas Chou thomas@wytron.com.tw

Signed-off-by: Wills Wang wills.wang@live.com

Changes in v7:

• remove map_physmem for debug port

Changes in v6:

• Remove wait loop in putc and getc
• Use map_physmem instead of KSEG1ADDR

Changes in v5:

• remove ar933x_serial_platdata
• Import document "qca,ar9330-uart.txt" from kernel
• Add support for debug UART

Changes in v4:

• Auto calculate baudrate for serial driver
• Move pinctrl code in serial driver into arch/mips/mach-ath79
• Use get_serial_clock to serial clock source

Changes in v3:

• Convert serial driver to driver model

Changes in v2:

• Move serial driver code into drivers/serial

.../serial/qca,ar9330-uart.txt | 24 ++ drivers/serial/Kconfig | 17 ++ drivers/serial/Makefile | 1 + drivers/serial/serial_ar933x.c | 254 +++++++++++++++++++++ 4 files changed, 296 insertions(+) create mode 100644 doc/device-tree-bindings/serial/qca,ar9330-uart.txt create mode 100644 drivers/serial/serial_ar933x.c

Reviewed-by: Simon Glass sjg@chromium.org

Would be good to have a commit message.