On Mon, Oct 6, 2008 at 4:26 PM, Wolfgang Denk wd@denx.de wrote:
Dear Kyungmin Park,
In message 20081006014744.GA5438@july you wrote:
RB-tree support on U-Boot Now it's used at UBI module. Of course other modules can use it.
...
I understand the code is a verbatim copy from the LInux kernel? Otherwise the coding style violations would not be acceptable.
Yes it's from kernel. I just removed EXPORT_SYMBOL.
diff --git a/lib_generic/Makefile b/lib_generic/Makefile index 7df5a2c..83b41ca 100644 --- a/lib_generic/Makefile +++ b/lib_generic/Makefile @@ -45,6 +45,7 @@ COBJS-y += string.o COBJS-y += strmhz.o COBJS-y += vsprintf.o COBJS-y += zlib.o +COBJS-y += rbtree.o
I expect that only few systems will actually use this, so it must be configurable. It makes no sense to build this for ALL systems. Please add a config option.
Agreed, I will add CONFIG_RBTREE.
I will re-send the updated patch.
Thank you, Kyungmin Park