On 5/24/19 7:10 AM, AKASHI Takahiro wrote:
File system tests, test_fs, relies on guestmount so that it can be executed in a user mode. Describe this in README.md.
It is unclear where commands from package libguestfs-tools are used. I could not find any script in directory test/ using it.
As already mentioned in reply to patch 4 of the series, please, provide clear instructions how to invoke the file system tests in this README.md.
make qemu_arm64_defconfig make python3 ./test/py/test.py --bd=qemu-arm64 --build-dir=.
is simply skipping all of them.
Best regards
Heinrich
Signed-off-by: AKASHI Takahiro takahiro.akashi@linaro.org
test/py/README.md | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/test/py/README.md b/test/py/README.md index 2156661d6c42..50b174b51960 100644 --- a/test/py/README.md +++ b/test/py/README.md @@ -25,15 +25,16 @@ On Debian or Debian-like distributions, the following packages are required. Some packages are required to execute any test, and others only for specific tests. Similar package names should exist in other distributions.
-| Package | Version tested (Ubuntu 14.04) | -| -------------- | ----------------------------- | -| python | 2.7.5-5ubuntu3 | -| python-pytest | 2.5.1-1 | -| python-subunit | - | -| gdisk | 0.8.8-1ubuntu0.1 | -| dfu-util | 0.5-1 | -| dtc | 1.4.0+dfsg-1 | -| openssl | 1.0.1f-1ubuntu2.22 | +| Package | Version tested (Ubuntu 14.04) | +| --------------- | ----------------------------- | +| python | 2.7.5-5ubuntu3 | +| python-pytest | 2.5.1-1 | +| python-subunit | - | +| gdisk | 0.8.8-1ubuntu0.1 | +| dfu-util | 0.5-1 | +| dtc | 1.4.0+dfsg-1 | +| openssl | 1.0.1f-1ubuntu2.22 | +| libguestfs-tools| 1:1.32.2-4ubuntu2.2 |
The test script supports either: