11 Feb
2022
11 Feb
'22
2:50 a.m.
Hi Tim,
Your patch looks good.
On Wed, Feb 2, 2022 at 7:00 PM Tim Harvey tharvey@gateworks.com wrote:
+/* Initial environment variables */ +#define CONFIG_EXTRA_ENV_SETTINGS \
BOOTENV \MEM_LAYOUT_ENV_SETTINGS \"script=boot.scr\0" \"bootm_size=0x10000000\0" \"ipaddr=192.168.1.22\0" \"serverip=192.168.1.146\0" \
It is not recommended to place hardcode ipaddr and serverip in the default environment. Please remove them.
+/* FEC */ +#define CONFIG_ETHPRIME "eth0" +#define CONFIG_FEC_XCV_TYPE RGMII +#define CONFIG_FEC_MXC_PHYADDR 0 +#define FEC_QUIRK_ENET_MAC +#define IMX_FEC_BASE 0x30BE0000
No need to pass IMX_FEC_BASE as the Ethernet driver model is used.
Reviewed-by: Fabio Estevam festevam@gmail.com