13 Dec
2011
13 Dec
'11
9:18 a.m.
Dear Aaron Williams,
In message 201112122215.11610.Aaron.Williams@cavium.com you wrote:
Commit c30a15e "FAT: Add FAT write feature" introduced a compiler warning. Fix this.
...
I know it's rather late to comment on this, but this patch breaks FAT write support.
How can it break something we don't have?
Currently there is no write support for (V)FAT file systems in mainline.
The commit removes a static variable of file scope, that was used in a single place, where a value was assigned to it. There was no place anywhere in the code twhere else this variable was referenced. So how can this break anything?
Please elucidate.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
For every complex problem, there is a solution that is simple, neat,
and wrong. - Mark Twain