On Fri, Jul 19, 2019 at 10:14:06AM +0200, Wolfgang Denk wrote:
Dear AKASHI Takahiro,
In message 20190717082525.891-5-takahiro.akashi@linaro.org you wrote:
This patch shows how environment storage drivers should be modified at the minimum to support contexts.
This commit message is misleading. No part of this patch is related to contexts. What it acually does is adding support for variable sized environment blocks. The commit message should be fixed.
Please note that this patch (or even all the patches in this set) are not intended to be merged as they are. This is an RFC in order for me to determine if you agree with the approach I take here or not. This is the primary goal. The code itself is nothing but a help for your understandings of my basic ideas.
Also this commit makes me wonder if you have tested your patches for bisectability.
Again, not.
Thanks, -Takahiro Akashi
it seems changes that belong to together (like making the envionment size variable) are split across patches. This needs probably refacturing / resorting.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de What can it profit a man to gain the whole world and to come to his property with a gastric ulcer, a blown prostate, and bifocals? -- John Steinbeck, _Cannery Row_