On Monday 11 May 2009 12:38:45 Stefan Roese wrote:
On Monday 11 May 2009 18:27:02 Mike Frysinger wrote:
On Monday 11 May 2009 10:03:55 Stefan Roese wrote:
This patch brings the U-Boot MTD infrastructure in sync with the current Linux MTD version (2.6.30-rc3). Biggest change is the 64bit device size support and a resync of the mtdpart.c file which has seen multiple fixes meanwhile.
really wish there was a define to control this. large devices are fine, but it sucks when majority of people dont hit this limit.
What is the drawback of this code version? I have to admit that I didn't compare code size, but this is the only possible drawback coming to my mind. And the advantages are big enough from my point of view. Being in sync with Linux once again not only brings 64bit device size support but removes quite a lot of bugs from the mtd infrastructure (for example used by UBI).
And frankly, cluttering the files with another set of #ifdef's doesn't really sound promising. Additionally this would make future sync's with the Linux version more troublesome.
i'd see most of the changes be via a typedef and thus there are no ifdefs cluttering up the code -mike