On Monday 31 October 2011 16:47:08 Simon Glass wrote:
On Mon, Oct 31, 2011 at 1:44 PM, Mike Frysinger wrote:
On Monday 31 October 2011 15:11:35 Simon Glass wrote:
On Sun, Oct 30, 2011 at 5:54 PM, Mike Frysinger wrote:
If we move the local funcs to the top of the file, and use the __maybe_unused define, we can drop a lot of ugly ifdef logic and duplicated prototypes.
Signed-off-by: Mike Frysinger vapier@gentoo.org
This is much cleaner - is the correct style to put attribute tags on the previous line?
when responding to add your own, there isn't any real protocol. just normal e-mail etiquette (no top posting/etc...). patchwork/humans will do the right thing when manually updating the changelog.
Actually I meant the __maybe_unused tag before the function name.
ah. i'm not sure there is a hard rule here. i did that because one line would make the func def too long to fit. -mike