Re: [U-Boot] [PATCH 2/3] drivers/gpio/pm8916_gpio.c: Make pid be uint32_t

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

Hi,

On 20.04.2016 23:25, Tom Rini wrote:

On Mon, Apr 18, 2016 at 10:23:24PM +0200, Mateusz Kulikowski wrote:

[..]

...

I think (now, when the coverity pointed out mistake) that we should add in that case check if pid fits in 16-bits, as this is maximum pid value on spmi bus.

This checks should be done in pm8916_gpio_probe() and pm8916_probe().

Would you like to do it in your series or want me to post another patch on top of them?

Please do a follow up, thanks!

Will do that, but it will take a few days as I have a lot of non-coding related assignments now :)

btw. SPMI core checks pid and sid internally during reads/writes so we're pretty safe anyway.

Regards, Mateusz