Re: [PATCH v3 16/17] tpm: Add a driver for H1/Cr50

6 Feb 2020


      On Wed, Feb 5, 2020 at 10:04 AM Simon Glass sjg@chromium.org wrote:
...
H1 is a Google security chip present in recent Chromebooks, Pixel phones
and other devices. Cr50 is the name of the software that runs on H1 in
Chromebooks.
This chip is used to handle TPM-like functionality and also has quite a
few additional features.
Add a driver for this.
Signed-off-by: Simon Glass sjg@chromium.org
Changes in v3:

Fix 'devuce' typo
s/@tpm/@dev/ in function comments
Use log_debug() instead of debug()
Fix 'consceivably' typo
Rewrite comment for claim_locality()
Shorten comment in cr50_i2c_wait_tpm_ready() to fit on one line

Changes in v2:

Significant rewrite of cr50 init procedure
Support use of interrupts

drivers/tpm/Kconfig    |  10 +
 drivers/tpm/Makefile   |   1 +
 drivers/tpm/cr50_i2c.c | 659 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 670 insertions(+)
 create mode 100644 drivers/tpm/cr50_i2c.c
Reviewed-by: Bin Meng bmeng.cn@gmail.com