On 12/3/23 09:30, Chanho Park wrote:
The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that part to output the correct timeout value.
Before --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (60s timeout)
After --> StarFive # wdt start 3000 WDT: Started watchdog@13070000 without servicing (3s timeout)
Fixes: c2fd0ca1a822 ("watchdog: Integrate watchdog triggering into the cyclic framework") Signed-off-by: Chanho Park chanho61.park@samsung.com
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
Change from v1:
Use lldiv to fix a build error of m68k arch
drivers/watchdog/wdt-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/watchdog/wdt-uclass.c b/drivers/watchdog/wdt-uclass.c index ed329284decb..417e8d7eef95 100644 --- a/drivers/watchdog/wdt-uclass.c +++ b/drivers/watchdog/wdt-uclass.c @@ -7,6 +7,7 @@
#include <common.h> #include <cyclic.h> +#include <div64.h> #include <dm.h> #include <errno.h> #include <hang.h> @@ -141,7 +142,7 @@ int wdt_start(struct udevice *dev, u64 timeout_ms, ulong flags)
printf("WDT: Started %s with%s servicing %s (%ds timeout)\n", dev->name, IS_ENABLED(CONFIG_WATCHDOG) ? "" : "out",
str, priv->timeout);
str, (u32)lldiv(timeout_ms, 1000));}
return ret;
Viele Grüße, Stefan Roese