Hello all,
On Tue, 13 Dec 2011 09:18:15 +0100 Wolfgang Denk wd@denx.de wrote:
Dear Aaron Williams,
In message 201112122215.11610.Aaron.Williams@cavium.com you wrote:
Commit c30a15e "FAT: Add FAT write feature" introduced a compiler warning. Fix this.
...
I know it's rather late to comment on this, but this patch breaks FAT write support.
How can it break something we don't have?
Currently there is no write support for (V)FAT file systems in mainline.
The commit removes a static variable of file scope, that was used in a single place, where a value was assigned to it. There was no place anywhere in the code twhere else this variable was referenced. So how can this break anything?
Please elucidate.
The FAT write support as submitted and included seems to be broken. The removed variable is referenced in fs/fat/fat_write.c, but in fs/fat/fat.c it is declared as static. This issue didn't show up because no board config file in mainline defines CONFIG_FAT_WRITE.
@ Donggeun Kim Could you please submit a patch fixing this?
Thanks, Anatolij