-----Original Message----- From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Siddarth Gore Sent: Thursday, March 18, 2010 10:59 AM To: Wolfgang Denk Cc: u-boot@lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik Subject: Re: [U-Boot] [PATCH] Marvell GuruPlug Board Support
...snip...
We have pretty much identical code already in mv_phy_88e1116_init() [in "board/Marvell/rd6281a/rd6281a.c"], in reset_phy() [in "board/Marvell/openrd_base/openrd_base.c"], in reset_phy(0 [in "board/Marvell/sheevaplug/sheevaplug.c"] and I don't know
where else.
I object against adding more and more copies of the same
code. Please
factor out the common part into a single implementation,
and call this
everwhere where such code is used. Thanks.
i can create a new file ethphy.c in board/Marvell/common and put this code there. but if we are going to move to a phy driver (as Prafulla suggested) then that wont be necessary. Please advise.
Also i think we should maintain different init functions for 1116 and 1121 as they represent different phy families, even though the code is pretty much the same right now.
Hi Siddarth
I think you keep this part as it is as of now, Once Ben suggest something, I will post the cleanup patch
Regards.. Prafulla ..