Re: [U-Boot] [PATCH v4 8/9] spl: dm: Make it possible for the SPL to pick its own DTB from a FIT

Hi Simon,

It's has been a month since you've reviewed the series, I think it's time that I send a v5. I tried to address all your remarks but I stumbled on this one below:

JJ

On 13/08/2017 23:35, Simon Glass wrote:

diff --git a/dts/Kconfig b/dts/Kconfig

...

index c78438a..ec91a71 100644 --- a/dts/Kconfig +++ b/dts/Kconfig @@ -118,6 +118,89 @@ config MULTI_DTB_FIT the correct DTB to be used. Use this if you need to support multiple DTBs but don't use the SPL.

+config SPL_MULTI_DTB_FIT

•   depends on SPL_LOAD_FIT && SPL_OF_CONTROL && !SPL_OF_PLATDATA
  

•   bool "support embedding several DTBs in a FIT image for the SPL"
  

Can you please capitalise the options in this file, so 'Bool'*

I tried to do that, but it didn't work. Could it be a matter of the host configuration ?

...

•   help
  

•     This option provides the SPL with the ability to select its own
  

•     DTB at runtime from an appended FIT image containing several DTBs.
  

•     This allows using the same SPL binary on multiple platforms.
  

•     The primary purpose is to handle different versions of
  

•     the same platform without tweaking the platform code if the
  

•     differences can be expressed in the DTBs (common examples are: bus
  

•     capabilities, pad configurations).
  

+config SPL_OF_LIST

•   string "List of device tree files to include for DT control in SPL"
  

•   depends on SPL_MULTI_DTB_FIT
  

•   default OF_LIST
  

•   help
  

•     This option specifies a list of device tree files to use for DT
  

•     control in the SPL. These will be packaged into a FIT. At run-time,
  

•     the SPL will select the correct DT to use by examining the
  

•     hardware (e.g. reading a board ID value). This is a list of
  

•     device tree files (without the directory or .dtb suffix)
  

•     separated by <space>.
  

+choice

•   prompt "SPL OF LIST compression"
  

•   depends on SPL_MULTI_DTB_FIT
  

•   default SPL_MULTI_DTB_FIT_LZO
  

+config SPL_MULTI_DTB_FIT_LZO

•   bool "LZO"
  

•   depends on SYS_MALLOC_F
  

•   select SPL_LZO
  

•   help
  

•     Compress the FIT image containing the DTBs available for the SPL
  

•     using LZO compression. (requires lzop on host).
  

+config SPL_MULTI_DTB_FIT_GZ