Hi Igal,
On 08.06.2017 08:06, Igal Liberman wrote:
On 07.06.2017 14:16, igall@marvell.com wrote:
From: Igal Liberman igall@marvell.com
Currently, Marvell Armada8k development board use 3 different defconfigs: mvebu_db-88f7040-nand_defconfig mvebu_db-88f7040_defconfig mvebu_db-88f8040_defconfig Having 3 different defconfigs makes maintenance difficult.
This patch removes the defconfigs mentioned above and introduce a new defconfig which represents the Armada8k family.
With this patch, no device-tree is set in the defconfig, so the device-tree should be set during compilation, using:
Configure u-boot:
make mvebu_db_armada8k_defconfigSelect the desired device-tree during compilation:
make DEVICE_TREE=armada-7040-db make DEVICE_TREE=armada-8040-db make DEVICE_TREE=armada-7040-db-nandI like the idea to consolidate the defconfigs in general. One question though. This patch results in one build target for the automated tests (Travis). Does compiling without the additional DEVICE_TREE= work without generating compilation errors? Otherwise the Travis tests will fail.
If you compile without DEVICE_TREE= it won't compile (unless you exported DEVICE_TREE before). Basically, I did it on purpose - to make sure that user doesn't rely on some possible incorrect default settings.
Makes sense.
If it causes a compilation issues for the automated tests - I guess we can set a default value after all. What do you think?
Yes, please do. We need to compile clean for the automated tests, otherwise this patch simply can't be accepted (sorry).
Thanks, Stefan